Read inner classes in signatures, force annotations after template parents #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class info. Before this, inherited members may not be visible at the point of forcing the annotation on a definition in the template. Also moved symbol cache to the initial context so that child contexts all pass to the same cache.
bishabosha
force-pushed
the
tasty/pick-erased-type-ref
branch
2 times, most recently
from
acc0d90
to
bd8bdd8
Compare
Inner classes can not be found with Mirror getRequiredClass, so we should have another way to compare types to signatures, this proposes to instead convert method signatures to Signature[ErasedTypeRef]
bishabosha
force-pushed
the
tasty/pick-erased-type-ref
branch
from
bd8bdd8
to
f8c2212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, inherited members may not be visible at the point of forcing the annotation
on a definition in the template.
Also moved symbol cache to the initial context so that child contexts all pass to the same
cache.
Inner classes can not be found with Mirror getRequiredClass, so
we should have another way to compare types to signatures, this
proposes to instead convert method signatures to
Signature[ErasedTypeRef]